Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd: Make machinectl work with NixOS #69422

Merged
merged 1 commit into from Oct 12, 2019
Merged

nixos/systemd: Make machinectl work with NixOS #69422

merged 1 commit into from Oct 12, 2019

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Sep 25, 2019 •
edited

Motivation for this change

Images generated with nixos-install will be supported by machinectl
problem is that systemd-nspawn's private usersns feature clashes
with DynamicUser and RuntimeDirectory features, which causes NixOS
images to not boot. There is an upstream issue for this
systemd/systemd#13622

Fixing this by running nspawn images without the user namespaces flag enabled
by default. People can still opt in to it manually by setting PrivateUsers=yes in their .nspawn file

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @flokli

@arianvp
nixos/systemd: Make machinectl work with NixOS
7058b0a 
Images generated with nixos-install will be supported by machinectl
problem is that systemd-nspawn's private usersns feature clashes
with DynamicUser and RuntimeDirectory features, which causes NixOS
images to not boot. There is an upstream issue for this
systemd/systemd#13622
@arianvp
Copy link
Member Author

arianvp commented Sep 25, 2019

Once we get privateusers fixed upstream, we can revert this change again. but it seems nice to have this in 19.09

@arianvp
Copy link
Member Author

arianvp commented Sep 25, 2019 •
edited

Even with this change, nscd doesn't work:

Nevermind I forgot to reboot the container :)

@flokli flokli merged commit e24526d into NixOS:master Oct 12, 2019
@flokli
Copy link
Contributor

flokli commented Oct 12, 2019

I'll leave the decision on whether to backport or not to @NixOS/backports.

@worldofpeace
Copy link
Contributor

Is this an improvement or did this used to work before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arianvp @flokli @worldofpeace