Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipman: init at 1.0.1 #69421

Merged
merged 1 commit into from Sep 26, 2019
Merged

clipman: init at 1.0.1 #69421

merged 1 commit into from Sep 26, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 25, 2019 •
edited

Motivation for this change

Simple clipboard manager for wayland: https://github.com/yory8/clipman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit September 25, 2019 16:06
@alexarice
Copy link
Contributor

@GrahamcOfBorg build clipman

@alexarice
Copy link
Contributor 

2019/09/25 18:17:42 Error running wl-copy: exec: "wl-copy": executable file not found in $PATH

Would it make sense to wrap this and add wl-clipboard to the path?

@Ma27
Copy link
Member Author

Ma27 commented Sep 25, 2019 •
edited

Yeah indeed. Missed that because I have wl-copy in my local profile, sorry!

EDIT: btw as it's optional to use rofi/dmenu, I'll not wrap those packages.

@Ma27
Copy link
Member Author

Ma27 commented Sep 25, 2019

@alexarice fixed. Would you mind taking another look at this? :)

@alexarice
Copy link
Contributor

I'm slightly confused, I've managed to store some text but it doesn't seem to interact with the clipboard. How do I use this?

@Ma27
Copy link
Member Author

Ma27 commented Sep 25, 2019

This is mainly used to persist stuff that also goes to a clipboard. I use it with sway as recommended in the readme: https://github.com/yory8/clipman#usage

alexarice
alexarice approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't bothered to change my sway config, but it does seem to be able to save stuff I pipe into it and display these with clipman pick. Tested with nix-review

jonringer
jonringer approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work (don't have wayland, but cli seems to work)
leaf package

@Ma27 Ma27 merged commit 70abf8c into NixOS:master Sep 26, 2019
@Ma27 Ma27 deleted the package-clipman branch September 26, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@alexarice alexarice alexarice approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @alexarice @jonringer