Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] signal-desktop: 1.27.2 -> 1.27.3 (backport) #69565

Merged
merged 2 commits into from Sep 26, 2019
Merged

[19.03] signal-desktop: 1.27.2 -> 1.27.3 (backport) #69565

merged 2 commits into from Sep 26, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Sep 26, 2019 •
edited

Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after 90 days).

Note: This will be the last backport for 19.03.
The build will expire on Tue Dec 24 21:29:17 UTC 2019.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@primeos
signal-desktop: Document the build "expiration"
47729d0 
This adds a comment why it's important to always backport any updates as
suggested in NixOS#68232. I've als included a few more details to document
the behaviour.

Sources:
- Default build lifetime [0]
- asar - Electron Archive [1]

[0]: https://github.com/signalapp/Signal-Desktop/blob/d3d2b0ec529ffd5ad74deb17831005a1acacc949/Gruntfile.js#L222
[1]: https://github.com/electron/asar

(cherry picked from commit 5d1abc6)
@primeos
signal-desktop: 1.27.2 -> 1.27.3
99f61ee 
(cherry picked from commit 6f3b44b)
@primeos
Copy link
Member Author

primeos commented Sep 26, 2019

@GrahamcOfBorg test signal-desktop

@ofborg ofborg bot requested a review from ixmatus September 26, 2019 18:25
@primeos primeos merged commit bd5e8f3 into NixOS:release-19.03 Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixmatus ixmatus Awaiting requested review from ixmatus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos