Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kicad: 5.1.2 -> 5.1.4 #69584

Merged
merged 4 commits into from
Oct 16, 2019
Merged

kicad: 5.1.2 -> 5.1.4 #69584

merged 4 commits into from
Oct 16, 2019
+9 −8

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Sep 26, 2019 •
edited
Loading

Motivation for this change

Update kicad and provide a partial fix for the ngspice issue.
With this the ngspice gui in eeschema Tools -> Simulation will open.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @berce

Sorry, something went wrong.

@tokudan
Copy link
Contributor Author

tokudan commented Sep 26, 2019

@GrahamcOfBorg build kicad

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 26, 2019
@mmahut
Copy link
Member

mmahut commented Sep 27, 2019

Fails on aarch64.

collect2: error: ld returned 1 exit status
[7904/7904] Linking CXX executable test/OCAFExport_test/OCAFExport_test
FAILED: test/OCAFExport_test/OCAFExport_test
: && /nix/store/bqaxflzgb6i1br71ilinf730lqc7wf2h-gcc-wrapper-8.3.0/bin/g++  -O3 -DNDEBUG  -rdynamic test/OCAFExport_test/CMakeFiles/OCAFExport_test.dir/OCAFExport_test.cpp.o  -o test/OCAFExport_test/OCAFExport_test  Unix/aarch64-Release-64/libFWOSPlugin.so.11.0.0 Unix/aarch64-Release-64/libTKBin.so.11.0.0 Unix/aarch64-Release-64/libgtest.a Unix/aarch64-Release-64/libTKCAF.so.11.0.0 Unix/aarch64-Release-64/libTKBO.so.11.0.0 Unix/aarch64-Release-64/libTKPrim.so.11.0.0 Unix/aarch64-Release-64/libTKV3d.so.11.0.0 Unix/aarch64-Release-64/libTKService.so.11.0.0 -lSM -lICE -lX11 -lfreeimage -lfontconfig Unix/aarch64-Release-64/libTKShHealing.so.11.0.0 -lGL -lGLU -lfreetype Unix/aarch64-Release-64/libTKMesh.so.11.0.0 Unix/aarch64-Release-64/libTKHLR.so.11.0.0 Unix/aarch64-Release-64/libTKTopAlgo.so.11.0.0 Unix/aarch64-Release-64/libTKGeomAlgo.so.11.0.0 Unix/aarch64-Release-64/libTKBRep.so.11.0.0 Unix/aarch64-Release-64/libTKGeomBase.so.11.0.0 Unix/aarch64-Release-64/libTKG3d.so.11.0.0 Unix/aarch64-Release-64/libTKG2d.so.11.0.0 Unix/aarch64-Release-64/libTKMath.so.11.0.0 Unix/aarch64-Release-64/libTKBinL.so.11.0.0 Unix/aarch64-Release-64/libTKLCAF.so.11.0.0 Unix/aarch64-Release-64/libTKCDF.so.11.0.0 Unix/aarch64-Release-64/libTKernel.so.11.0.0 -ldl -lm -lpthread && :
/nix/store/fm9jqjh7qgamlb2pllm6vaw7kgannx3s-binutils-2.31.1/bin/ld: /nix/store/19x7dfkrszzp540hi9ighhrx652h16x3-freeimage-3.18.0/lib/libfreeimage.so: undefined reference to `png_init_filter_functions_neon'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
builder for '/nix/store/9kifcs5r29rkr8gxckn8a5ks3g2wxwd7-opencascade-oce-0.18.3.drv' failed with exit code 1
cannot build derivation '/nix/store/2dvpbqnhpwzxjva65z3fqwgdlflylf18-kicad-5.1.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2dvpbqnhpwzxjva65z3fqwgdlflylf18-kicad-5.1.4.drv' failed```

@tokudan
Copy link
Contributor Author

tokudan commented Sep 29, 2019

let's see if that fixes the aarch64 build.
@GrahamcOfBorg build kicad

@tokudan tokudan changed the title kicad: 5.1.2 -> 5.1.4 kicad: 5.1.2 -> 5.1.4 [WIP] Sep 30, 2019
@tokudan
Copy link
Contributor Author

tokudan commented Sep 30, 2019

another try....
@GrahamcOfBorg build kicad

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/kicad-version-update/4222/1

@tokudan
Copy link
Contributor Author

tokudan commented Oct 12, 2019 •
edited
Loading

With the last commit I've successfully run a very basic simulation, so the ngspice simulation is now working.
Thanks to @SnVIZQ for the patch.
The only remaining issue is the aarch64 build. I'll make a quick test if the old version had a successful build.
@GrahamcOfBorg build kicad

@tokudan tokudan mentioned this pull request Oct 12, 2019
Closed
@veprbl
Copy link
Member

veprbl commented Oct 12, 2019

The aarch64 build has been broken for around 3 months now: https://hydra.nixos.org/job/nixpkgs/trunk/kicad.aarch64-linux/all?page=1

Perhaps it would be okay to just mark the package with broken = stdenv.isAarch64. If you want to fix it on aarch64 that would be great too. Perhaps you could try applying for https://github.com/nix-community/aarch64-build-box .

@tokudan
Copy link
Contributor Author

tokudan commented Oct 12, 2019

@veprbl I have no idea what the issue with this neon error is, so I've marked it as broken for aarch64.
@GrahamcOfBorg build kicad

@tokudan tokudan changed the title kicad: 5.1.2 -> 5.1.4 [WIP] kicad: 5.1.2 -> 5.1.4 Oct 12, 2019
@tokudan
Copy link
Contributor Author

tokudan commented Oct 12, 2019 •
edited
Loading

[this comment is irrelevant now]

@tokudan tokudan changed the title kicad: 5.1.2 -> 5.1.4 kicad: 5.1.2 -> 5.1.4 [WIP] Oct 12, 2019
@tokudan
Copy link
Contributor Author

tokudan commented Oct 13, 2019

I've picked these commits now, they allow me to run a very basic simulation, update kicad and disable the aarch64 build.
pick 06516fe13ad kicad: 5.1.2 -> 5.1.4
pick 0f39c86bdc7 kicad: mark is broken on aarch64 due to some neon issue.
pick 95a7a83df70 kicad: partial fix for the ngspice segfault

@tokudan
Copy link
Contributor Author

tokudan commented Oct 13, 2019

@GrahamcOfBorg build kicad

@tokudan tokudan changed the title kicad: 5.1.2 -> 5.1.4 [WIP] kicad: 5.1.2 -> 5.1.4 Oct 13, 2019
@tokudan
Copy link
Contributor Author

tokudan commented Oct 13, 2019

Hopefully this PR is now really done.

@tokudan @veprbl
Fix packages3d sha
8d91afe 
Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@tokudan
Copy link
Contributor Author

tokudan commented Oct 14, 2019

I didn't know about kicad-with-packages3d before, so that hopefully fixes everything now.

@veprbl veprbl merged commit b4136a8 into NixOS:master Oct 16, 2019
@veprbl
Copy link
Member

veprbl commented Oct 16, 2019

@tokudan Thank you!

@tokudan tokudan deleted the kicad514 branch October 17, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tokudan @mmahut @nixos-discourse @veprbl