Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffr: init at 0.1.2 #69505

Merged
merged 1 commit into from Sep 26, 2019
Merged

diffr: init at 0.1.2 #69505

merged 1 commit into from Sep 26, 2019

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Sep 26, 2019

Motivation for this change

Add a package for diffr. I've opened mookid/diffr#29 about being able to run tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

me!

Signed-off-by: David Wood <david@davidtw.co>
@Ma27
Copy link
Member

Ma27 commented Sep 26, 2019

@GrahamcOfBorg build diffr

@Ma27
Copy link
Member

Ma27 commented Sep 26, 2019

Also tested locally 👍

@Ma27 Ma27 merged commit 67aa6ba into NixOS:master Sep 26, 2019
@davidtwco davidtwco deleted the diffr-init branch September 26, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants