linuxPackages.virtualboxGuestAdditions: apply mp-r0drv-linux.c patch #69500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These don't use a the virtualbox sources, but an iso as src, and we need to add the kernel 5.3 patch aswell. As for some reason the source files are present on the .iso with Windows Line endings (sic!), call dos2unix first. Unfortunately, we can't use the same kernel-5.3-fix.patch as virtualbox itself, as some files are missing and paths are different.
|
what do you mean by "patch for host virtualbox"? |
|
The commit from #69323 as it hasn't been built into unstable channel yet. Since my system is pointed at that channel I figured it would isolate these changes without introducing anything from head of master since it seems there are a lot of tests failing on hydra right now. |
|
Alright :-) |
|
Backported to 19.09 in 9c9bd27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't use a the virtualbox sources, but an iso as
src, and we needto add the kernel 5.3 patch aswell.
As for some reason the source files are present on the .iso with Windows
Line endings (sic!), call
dos2unixfirst.Unfortunately, we can't use the same
kernel-5.3-fix.patchasvirtualboxitself, as some files are missing and paths are different.
Motivation for this change
Fixes #65689.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @wkral @ambrop72