Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ebdc4419310d
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bd5e8f35c2e9
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 26, 2019

  1. signal-desktop: Document the build "expiration" 

    This adds a comment why it's important to always backport any updates as
suggested in #68232. I've als included a few more details to document
the behaviour.

Sources:
- Default build lifetime [0]
- asar - Electron Archive [1]

[0]: https://github.com/signalapp/Signal-Desktop/blob/d3d2b0ec529ffd5ad74deb17831005a1acacc949/Gruntfile.js#L222
[1]: https://github.com/electron/asar

(cherry picked from commit 5d1abc6)
    @primeos
    primeos committed Sep 26, 2019
    Copy the full SHA
    47729d0 View commit details

  2. signal-desktop: 1.27.2 -> 1.27.3 

    (cherry picked from commit 6f3b44b)
    @primeos
    primeos committed Sep 26, 2019
    Copy the full SHA
    99f61ee View commit details

  3. Merge pull request #69565 from primeos/signal-desktop-backport 

    [19.03] signal-desktop: 1.27.2 -> 1.27.3 (backport)
    @primeos
    primeos authored Sep 26, 2019
    Copy the full SHA
    bd5e8f3 View commit details
Showing with 8 additions and 2 deletions.
  1. +8 −2 pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
10 changes: 8 additions & 2 deletions pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
View file
Original file line number Diff line number Diff line change
@@ -58,11 +58,17 @@ let

in stdenv.mkDerivation rec {
name = "signal-desktop-${version}";
version = "1.27.2";
version = "1.27.3"; # Please backport all updates to the stable channel.
# All releases have a limited lifetime and "expire" 90 days after the release.
# When releases "expire" the application becomes unusable until an update is
# applied. The expiration date for the current release can be extracted with:
# $ grep -a "^{\"buildExpiration" "${signal-desktop}/libexec/resources/app.asar"
# (Alternatively we could try to patch the asar archive, but that requires a
# few additional steps and might not be the best idea.)

src = fetchurl {
url = "https://updates.signal.org/desktop/apt/pool/main/s/signal-desktop/signal-desktop_${version}_amd64.deb";
sha256 = "08qh7867bc6z6mdbdilqdacx67n0kaxl3m4m97k0jxhd093a8xfz";
sha256 = "1c9arwnwa0lirvkwm0rfknabqn5gkznihxl1p2m6j7cs7hwhhsn2";
};

phases = [ "unpackPhase" "installPhase" ];