Add applet gpio.pca953x #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with the new group. I thought a "logic probe" applet frontend that just exposes a useful UI (curses?) for poking/prodding the glasgow ports would be useful, and it should fit within that category. This sounds like it could be useful to generalize over all backends that support GPIO operation (be it the raw Glasgow pins or an I2C expander or anything else, e.g. JTAG boundary scan anyone?), but that can happen later. |
electroniceel
force-pushed
the
stuff
branch
from
413a851
to
37c2b4e
Compare
|
incorporated all the review from irc |
whitequark
requested changes
Oct 2, 2019
|
adapted to current glasgow upstream (like the change from i2c_master to i2c_initiator) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to further verify the test jig board works. Although I know that this applet can't be used to control the test jig in production (as that will be connected to the internal i2c of the Glasgow), I thought writing an applet for it would be the easiest way to test the i2c io extender on it. Also I wanted to write an applet to get a feeling for how easy that is.
So here is my first applet. I tried to match the style I saw in some of the other applets, hope I got that right.
I thought creating the new "gpio" applet group was the best way to group this applet. Similar applets, like for the pcf8574, mcp23017 or the ports on glasgow itself, would also fit here. Another option might be the "control" group, but I think gpio and io extenders are specific enough to warrant their own group.