Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.patience_diff: init at 0.12.0 for OCaml ≥ 4.07 and related additions #69420

Merged
merged 4 commits into from
Oct 3, 2019
Merged

ocamlPackages.patience_diff: init at 0.12.0 for OCaml ≥ 4.07 and related additions #69420

merged 4 commits into from
Oct 3, 2019
+29 −0

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 25, 2019

Motivation for this change

Dependencies of patdiff at version 0.12.0, compatible with OCaml ≥ 4.07

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

vbgl added 4 commits September 25, 2019 15:39
@vbgl
ocamlPackages.sexp_pretty: init at 0.12.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a378609
@vbgl
ocamlPackages.expect_test_helpers_kernel: init at 0.12.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6c596da
@vbgl
ocamlPackages.expect_test_helpers: init at 0.12.0
9dda7c8
@vbgl
ocamlPackages.patience_diff: init at 0.12.0
c57760a
@vbgl vbgl added 8.has: package (new) This PR adds a new package 6.topic: ocaml labels Sep 25, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 25, 2019
@vbgl vbgl merged commit dc6b299 into NixOS:master Oct 3, 2019
@vbgl vbgl deleted the patdiff-0.12.0+deps branch October 3, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl