Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fancontrol: init #69398

Merged
merged 8 commits into from Sep 25, 2019
Merged

nixos/fancontrol: init #69398

merged 8 commits into from Sep 25, 2019

Conversation

evils
Copy link
Member

@evils evils commented Sep 25, 2019 •
edited

Motivation for this change

lm-sensors comes with fancontrol but nixos doesn't have a module for it yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

though no maintainer is listed for lm-sensors,
cc @dtzWill

evils and others added 2 commits September 25, 2019 13:28
evils and others added 2 commits September 25, 2019 17:24
@evils @markuskowa
Update nixos/modules/services/hardware/fancontrol.nix
44e2ff2 
Co-Authored-By: markuskowa <markus.kowalewski@gmail.com>
@evils @markuskowa
Update nixos/modules/services/hardware/fancontrol.nix
6765f04 
Co-Authored-By: markuskowa <markus.kowalewski@gmail.com>
markuskowa
markuskowa approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats to your first PR.

@markuskowa markuskowa merged commit 389c287 into NixOS:master Sep 25, 2019
@evils evils mentioned this pull request Oct 15, 2019
Closed
10 tasks
evils added a commit to evils/nixpkgs that referenced this pull request Oct 16, 2019
@evils
lm_sensors: fancontrol: NixOS#70933 + NixOS#69398
5829a0a
@evils evils mentioned this pull request Oct 27, 2019
Merged
10 tasks
@evils
Copy link
Member Author

evils commented Jun 2, 2020

@markuskowa what's up with the revert branch https://github.com/NixOS/nixpkgs/tree/revert-69398-fancontrol ?

@markuskowa
Copy link
Member

Not sure where that branch comes from. Must have been an accident. As far as I can see it was never merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evils @markuskowa @Janik-Haag