Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Add pitch parameter for helix extrusion #488

Closed
kalle opened this issue Sep 20, 2019 · 3 comments · Fixed by #1074
Closed

Feature request: Add pitch parameter for helix extrusion #488

kalle opened this issue Sep 20, 2019 · 3 comments · Fixed by #1074
Labels
enhancement UI
Milestone
4.0

Comments

@kalle
Copy link

kalle commented Sep 20, 2019

To make it easier to crate threads that should match some predefined pitch, I suggest that the pitch of the helix extrusion can be entered in a text box for that group. The height of the helix can be set in the diagram. The current solution with free-hand twisting makes it hard to get a desired pitch.
@phkahler
Copy link
Member

This should be a "pitch" parameter in the text window for the group. That parameter would be used to constrain the helix angle and the length along the axis. distance = (angle/2pi) * pitch.

From an implementation point of view, I'm not sure what to do when the user doesn't specify a pitch value, or how to dynamically create or remove the constraint equation from the group when changed in the text window. For helix, the angle/2 is in param[3] and the distance in param[7].

@whitequark
Copy link
Contributor

@phkahler I know how to do this. I'll try and implement it once I get around to reviews/merges (soon).

@phkahler phkahler added the UI label Mar 30, 2020
@phkahler
Copy link
Member

@whitequark I'm really interested in how to do this. I know how to create an internal constraint when a group is created, but this one wants to be created afterword (and maybe deleted) when the user may have created others manually.

@phkahler phkahler added this to the 4.0 milestone Nov 17, 2020
@giannissc giannissc mentioned this issue Dec 11, 2020
Closed
@phkahler phkahler changed the title Feature request: Improve percision of helix extrusion Feature request: Add pitch parameter for helix extrusion May 16, 2021
@phkahler phkahler linked a pull request Jul 25, 2021 that will close this issue
Add optional helix pitch constraint. WIP #1074
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement UI
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Add optional helix pitch constraint. WIP phkahler/solvespace
3 participants
@whitequark @kalle @phkahler