Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce closure size of Qt applications #69426

Merged
merged 10 commits into from Sep 26, 2019
Merged

Reduce closure size of Qt applications #69426

merged 10 commits into from Sep 26, 2019

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 25, 2019 •
edited

Motivation for this change

Fixes: #69272

This removes all the -dev outputs from the runtime closure of Qt applications that I found by looking at the closure of the graphical installer ISO. There may yet be others, but I think this is enough to remove the blocker once backported to NixOS 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

CC: @lovek323 (SDL), @7c6f434c (spandsp), @yegortimoshenko (ibus)

@ttuegel ttuegel added this to the 19.09 milestone Sep 25, 2019
@ttuegel ttuegel mentioned this pull request Sep 25, 2019
Merged
10 tasks
@ttuegel ttuegel removed this from the 19.09 milestone Sep 25, 2019
@veprbl
Copy link
Member

veprbl commented Sep 25, 2019

@GrahamcOfBorg eval

@ttuegel ttuegel merged commit 02eec3e into NixOS:staging Sep 26, 2019
@jonringer
Copy link
Contributor

there's quite a few like this:

builder for '/nix/store/dn35q0hd08zrjvzkz25zmb958ia332lb-libkscreen-5.16.5.drv' failed with exit code 1; last 10 log lines:
    with requested version "5.12.0".

    The following configuration files were considered but not accepted:

      /nix/store/vwsj5vlvkf00laiqfy0yg5wxkx2xdm40-qtbase-5.11.3-dev/lib/cmake/Qt5/Qt5Config.cmake, version: 5.11.3



  -- Configuring incomplete, errors occurred!
  See also "/build/libkscreen-5.16.5/build/CMakeFiles/CMakeOutput.log".

@ttuegel
Copy link
Member Author

ttuegel commented Sep 26, 2019

@jonringer Where do you see that? Qt 5.11 should not even exist in staging.

@jonringer
Copy link
Contributor

it was while doing a nix-review....

however i did nix-build -A plasma5.libkscreen on staging, and it seems to be building fine. Disregard :)

nix-review might not play nicely with other branches than master :/

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 30, 2019
@ttuegel @dtzWill
Merge pull request NixOS#69426 from ttuegel/closure-size/qt
400091f 
Reduce closure size of Qt applications

(cherry picked from commit 02eec3e)
This was referenced Oct 5, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lukateras lukateras Awaiting requested review from lukateras

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: closure-size 6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @veprbl @jonringer