Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

photoqt: use qt5's mkDerivation #76433

Merged
merged 1 commit into from Jan 8, 2020
Merged

photoqt: use qt5's mkDerivation #76433

merged 1 commit into from Jan 8, 2020

Conversation

valencik
Copy link
Contributor

Motivation for this change

Prior to this PR photoqt would compile but fail on start with the following error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

zsh: abort (core dumped) result/bin/photoqt

I followed https://nixos.wiki/wiki/Qt and #65399 to fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

worldofpeace
worldofpeace suggested changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use mkDerivation instead of stdenv.mkDerivation?
This is actually the qt specific deriver which automatically adds wrapQtAppsHook.

@worldofpeace
Copy link
Contributor

I will backport this change to stable.

@valencik
Copy link
Contributor Author

valencik commented Jan 3, 2020

@worldofpeace Could I get another review on this?
And is there anything I can do to help backport to stable?

@worldofpeace worldofpeace changed the title Fix photoqt by adding wrapQtAppsHook photoqt: use qt5's mkDerivation Jan 8, 2020
@worldofpeace worldofpeace merged commit 09863a6 into NixOS:master Jan 8, 2020
@worldofpeace
Copy link
Contributor

@worldofpeace Could I get another review on this?
And is there anything I can do to help backport to stable?

Your pinged helped a lot 👍

I've merged your pull request, and I've backported the change to stable in

If you'd like to submit a backport pull request to nixpkgs, see the following documentation

In this case, it was necessary because the binaries could not execute properly at all on stable.

@valencik valencik deleted the photoqt-qtwrap branch January 8, 2020 02:10
@notpeelz notpeelz mentioned this pull request Apr 22, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valencik @worldofpeace