Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-site.css: Don't hyphenate code blocks #323

Merged
merged 1 commit into from Dec 24, 2019
Merged

nixos-site.css: Don't hyphenate code blocks #323

merged 1 commit into from Dec 24, 2019

Conversation

gustavderdrache
Copy link
Contributor

On some screen widths (notably those of mobile devices), code blocks can trigger hyphenation:

Screenshot from 2019-12-24 13-27-50

This can be confusing to users, since the hyphen isn't copied (it's just a CSS artifact), and could cause even more issues if the user is typing these instructions in from another device - in the paragraph just above the screenshot, there is a code block instructing the user to run systemctl start display-manager – the hyphen there matters since it's the actual name of the service.

This PR addresses that issue by preventing hyphenation of any .command and .code blocks, since it appears to be mostly the DocBook-related sections that are most affected:

Screenshot from 2019-12-24 13-27-31

@zimbatm zimbatm merged commit 3941bc4 into NixOS:master Dec 24, 2019
@gustavderdrache gustavderdrache deleted the no-code-hyphens branch December 24, 2019 21:53
@ghost ghost mentioned this pull request Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants