Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.11.28 -> 2019.12.25 #76452

Merged
merged 1 commit into from Dec 26, 2019
Merged

youtube-dl: 2019.11.28 -> 2019.12.25 #76452

merged 1 commit into from Dec 26, 2019

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 24, 2019 •
edited

Motivation for this change

https://github.com/ytdl-org/youtube-dl/releases/tag/2019.12.25

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@zowoq zowoq changed the title youtube-dl: 2019.11.28 -> 2019.12.12 youtube-dl: 2019.11.28 -> 2019.12.25 Dec 24, 2019
@Ma27 Ma27 merged commit 9ba6cc9 into NixOS:master Dec 26, 2019
@zowoq zowoq deleted the youtube-dl branch December 26, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phreedom Phreedom Awaiting requested review from Phreedom

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@fpletz fpletz Awaiting requested review from fpletz

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @Ma27