Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current version has performance regressions #534

Closed
prototype99 opened this issue Dec 22, 2019 · 7 comments
Closed

current version has performance regressions #534

prototype99 opened this issue Dec 22, 2019 · 7 comments
Labels

Comments

@prototype99
Copy link

System information

SolveSpace version: 3.0~dcdfdec5

Operating system: Gentoo 17.0

Expected behavior

Performance is the same as, or better than version 2.3

Actual behavior

most changes seem to take a lot longer, although changing the camera is still snappy.

Additional information

room-plan.zip

@whitequark
Copy link
Contributor

Are you building SolveSpace yourself? Are you building a release version?

@ghost
Copy link

ghost commented Dec 23, 2019

pic.1

According its screenshot FPS reached 1675 1/s. What is performance with SolveSpace 2.3 on same scene on your PC?

Could you also give more details on your configuration

pic.1

Also, seems like few group has not hard constrained (1 or more DOF in groups)

pic.2

P.S.: As for me, latest nightly builds of SolveSpace 3.x (maybe, 3.0~690f87c) for Debian 9.x has much better performance than previous 3.x builds and 2.3 release

@prototype99
Copy link
Author

Are you building SolveSpace yourself? Are you building a release version?

building myself, I used CMAKE_BUILD_TYPE="Release" in case that makes a big difference. the commit used is based on the last time the changelog was updated, with the intention to go back later and see if there's any later commits I may want to give a try if I have any issues.

(screenshot)

According its screenshot FPS reached 1675 1/s. What is performance with SolveSpace 2.3 on same scene on your PC?

That seems to be more the fps for displaying the model, that has always been smooth, but in 2.3 dragging models around is smooth whereas in the 3.x version I used, not so much. same goes for sketching in 3d and dragging unconstrained lines in sketches.

Could you also give more details on your configuration

Model: Dell Latitude E6330 laptop system.
Ram: 8GB DDR3
CPU: Intel "ivybridge" i5-3320M
Opengl vendor: Intel
Renderer: Mesa DRI Intel Ivybridge mobile
Version: 4.2 (core profile) mesa 19.1.8

Also, seems like few group has not hard constrained (1 or more DOF in groups)

the current assembly objects I'm working on, so it's expected

P.S.: As for me, latest nightly builds of SolveSpace 3.x (maybe, 3.0~690f87c) for Debian 9.x has much better performance than previous 3.x builds and 2.3 release

That one is older than my version, but I will check it anyway, if it performs better that would at least narrow down when performance changed

@ghost
Copy link

ghost commented Dec 23, 2019

Also, seems like few group has not hard constrained (1 or more DOF in groups)

the current assembly objects I'm working on, so it's expected

To be honest, in SolveSpace (from my personal experience) you should hard constrain all entities in all previous groups and work with only last group.

@ghost
Copy link

ghost commented Dec 23, 2019

P.S.: As for me, latest nightly builds of SolveSpace 3.x (maybe, 3.0~690f87c)

That one is older than my version, but I will check it anyway,

I should be clear here: all new nightly builds since 3.0~690f87c

latest nightly builds of SolveSpace 3.x (maybe, since 3.0~690f87c) for Debian 9.x has much better performance than previous 3.x builds and 2.3 release

@prototype99
Copy link
Author

I should be clear here: all new nightly builds since 3.0~690f87c

so potentially it's specific to certain hardware, or due to a difference in how it's built?

@phkahler
Copy link
Member

phkahler commented Oct 1, 2020

@prototype99 Did you ever find out where the performance regression came from?

Also since you're building from source there have been some improvements. Try the following with master:

cmake .. -DCMAKE_BUILD_TYPE=Release -DENABLE_OPENMP=yes -DENABLE_LTO=yes

LTO will take a lot longer to build but gives another boost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants