New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional redwax modules #76417
Additional redwax modules #76417
Conversation
Do you have a working |
Aanderse - still working on extracting that -- my test is currently tied in with some proprietary HSM code - which I am swapping for OpenSC/pcsclite. |
Ok - got a bunch of example files liberated and working in our end to end test. E.g. for the time stamping: https://pastebin.com/GsSHj3DB What is the proper way to add an example to a pull request ? Or make it part of the overal body of examples ? |
@dirkx looking good 👍 I'm playing with your test example and will get back to you in the next couple days... but I think this is good to merge. Thanks for the work on this! |
@dirkx I threw together a nixos test. Generally we don't make nixos tests for packages, just modules, unless there is a pressing need. Personally I think we should have tests for packages which do cool things like this one... 😎 but I'll leave that decision up to someone else. Take a look and see if my test makes sense based on your pastebin: master...aanderse:redwax NOTE: There have been some changes to the |
That makes perfect sense; I've since simplified the test a fair bit (the `fatal' error is that it reuses the cert for the server -- which tools like MS-Word do not like) - but I guess better to wait for this PR to finish before embarking on sanitising the tests for all modules.
|
Slightly simplified and more realistic test at https://gist.github.com/dirkx/e4dc43ebcea0b3f372f5d6a3dce302e5. Is it ok to use things like <(echo foo) in these scripts - or strictly bourne-shell neutral ? |
@GrahamcOfBorg build mod_ca mod_crl mod_csr mod_ocsp mod_scep mod_pkcs12 mod_spkac mod_timestamp |
@aanderse is there a way to kick off the tests `raw' without firing up the kvm/qemu isolation (as this is 90+ second affair from the docker containers that I use) ? |
Did not mean to close this. Slip of the mouse/finger. |
@dirkx thanks again for contributing this! I'm excited to see someone using apache
I think NixOS tests are tied to qemu, but I don't know all the details because I've never looked at the implementation. If you post questions like this on https://discourse.nixos.org/ you will get great answers... better than I can give you 😄 |
Ack - will do & will do a PR for the test/example use cases for the other modules too. |
Submission of redwax modules to NixOS packages; including comments from review on #75620.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @