Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openimageio2: 2.0.12 -> 2.1.9.0 #76358

Merged
merged 1 commit into from Dec 25, 2019
Merged

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openimageio/versions.

meta.description for openimageio2 is: '"A library and tools for reading and writing images"'.

meta.homepage for openimageio2 is: '"http://www.openimageio.org"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
openimageio2

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/7axwcf3cd5gf8khqad9ah3wwrkj2xlw0-openimageio-2.1.9.0-bin \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A openimageio2 https://github.com/r-ryantm/nixpkgs/archive/43a81a393ee0f40fa7b0d8495b582d691765f9dc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/7axwcf3cd5gf8khqad9ah3wwrkj2xlw0-openimageio-2.1.9.0-bin
ls -la /nix/store/7axwcf3cd5gf8khqad9ah3wwrkj2xlw0-openimageio-2.1.9.0-bin/bin

cc @cillianderoiste @jtojnar for testing.

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay: AcademySoftwareFoundation/OpenImageIO@Release-2.0.12...Release-2.1.9.0#diff-8b1c3fd0d4a6765c16dfd18509182f9d

  • There are some new dependencies (e.g. HEIF/HEIC support) but I guess we can add them when somebody needs them.
  • They revamped their CMake build system
    • Checked that .pc file contains correct multi-output paths. Looks okay.
    • Tried to check that cmake modules contain correct paths. Does not look like it since the newly added $dev/lib/cmake does not contain any reference to $out. But we would need to try to link to it using CMake to be sure 🤢 And I doubt it worked before since there was only $out/share/cmake/Modules/FindOpenImageIO.cmake, which did not contain $dev refs.

@ofborg ofborg bot requested a review from jtojnar December 25, 2019 03:31
@jtojnar jtojnar merged commit d059e1a into NixOS:master Dec 25, 2019
@r-ryantm r-ryantm deleted the auto-update/openimageio branch January 6, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants