Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware-linux-nonfree: 2019-10-22 -> 2019-12-15 #76394

Merged
merged 1 commit into from Dec 26, 2019
Merged

firmware-linux-nonfree: 2019-10-22 -> 2019-12-15 #76394

merged 1 commit into from Dec 26, 2019

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Dec 24, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@ofborg ofborg bot requested a review from fpletz December 24, 2019 12:54
@Enzime
Copy link
Member Author

Enzime commented Dec 25, 2019

@GrahamcOfBorg build firmwareLinuxNonfree

@fpletz fpletz merged commit 9f139fe into NixOS:master Dec 26, 2019
@fpletz
Copy link
Member

fpletz commented Dec 26, 2019

Thanks!

@Enzime Enzime deleted the update-nonfree-firmware branch December 26, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Enzime @fpletz