Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Default "export" filename stem to same as slvs file #538

Closed
rpavlik opened this issue Dec 23, 2019 · 4 comments
Closed

RFE: Default "export" filename stem to same as slvs file #538

rpavlik opened this issue Dec 23, 2019 · 4 comments

Comments

@rpavlik
Copy link
Contributor

rpavlik commented Dec 23, 2019

Just a UI nitpick. If I get the chance I'll look into doing this myself.

System information

SolveSpace version: 3.0~64c0f62b

Operating system: Debian Buster

Expected behavior

I have a solvespace file. I go to export it to trimesh (to get an STL to 3d print). The dialog probably should open to the location of the slvs file and defaulting to the same stem but with the appropriate extension (.stl)

Actual behavior

It defaults to "untitled" (untitled.stl) in some other directory - think it's the last directory I used that export option in.

@whitequark
Copy link
Contributor

It defaults to "untitled" (untitled.stl) in some other directory - think it's the last directory I used that export option in.

That's on purpose: suppose you are exporting many files in some other directory (like "Outputs" in the root of your projects).

@rpavlik
Copy link
Contributor Author

rpavlik commented Dec 31, 2019

ah, so it's a workflow problem on my part that I tend to have my stl files live next to the slvs files and edit one model at a time :)

Would defaulting the name to match the model make sense, though?

@whitequark
Copy link
Contributor

Yep. That's how it worked before 6b5db58; it looks like I forgot to add functionality that sets the file stem. You should be able to use Platform::Path and FileDialog::SetCurrentName to add this back easily.

@whitequark whitequark changed the title RFE: Default "export" filename stem and directory to same as slvs file RFE: Default "export" filename stem to same as slvs file Dec 31, 2019
@whitequark
Copy link
Contributor

Regarding your workflow, I would expect you to use solvespace-cli, seeing as you're (I assume) comfortable with command line.

nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Mar 21, 2020
Went through first the diff of the referenced commit,
then all instances of "Create(Open|Save)FileDialog";
added SetFilename() calls where a default exists.

This has been previously removed in
6b5db58
Closes solvespace#538
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Mar 21, 2020
Went through first the diff of the referenced commit,
then all instances of "Create(Open|Save)FileDialog";
added SetFilename() calls where a default exists.

This has been previously removed in
6b5db58
Closes solvespace#538
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Mar 25, 2020
Went through first the diff of the referenced commit,
then all instances of "Create(Open|Save)FileDialog";
added SuggestFilename() calls where a default exists

This has been previously removed in
6b5db58
Closes solvespace#538
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue May 4, 2020
Went through first the diff of the referenced commit,
then all instances of "Create(Open|Save)FileDialog";
added SuggestFilename() calls where a default exists

This has been previously removed in
6b5db58
Closes solvespace#538
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Jun 27, 2020
Went through first the diff of the referenced commit,
then all instances of "Create(Open|Save)FileDialog";
added SuggestFilename() calls where a default exists

This has been previously removed in
6b5db58
Closes solvespace#538
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Sep 23, 2020
Went through first the diff of the referenced commit,
then all instances of "Create(Open|Save)FileDialog";
added SuggestFilename() calls where a default exists

This has been previously removed in
6b5db58
Closes solvespace#538
ruevs pushed a commit to nabijaczleweli/solvespace that referenced this issue Nov 25, 2020
Went through first the diff of the referenced commit,
then all instances of "Create(Open|Save)FileDialog";
added SuggestFilename() calls where a default exists

This has been previously removed in
6b5db58
Closes solvespace#538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants