Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offlineimap: add proxy dependency #76347

Merged
merged 2 commits into from Dec 26, 2019
Merged

offlineimap: add proxy dependency #76347

merged 2 commits into from Dec 26, 2019

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Dec 24, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Nobody

@Vonfry Vonfry mentioned this pull request Dec 24, 2019
Merged
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/97

@nlewo
Copy link
Member

nlewo commented Dec 26, 2019

Since the proxy is a standard configuration option, I think this dependency should be added by default. Could you compare the closure size before and after adding it to the derivation (nix path-info -S ./result)?

nlewo
nlewo requested changes Dec 26, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf my previous comment also.

pkgs/tools/networking/offlineimap/default.nix Outdated
@@ -23,7 +23,10 @@ python2Packages.buildPythonApplication rec {
doCheck = false;

nativeBuildInputs = [ asciidoc libxml2 libxslt docbook_xsl ];
propagatedBuildInputs = with python2Packages; [ six kerberos rfc6555 ];
propagatedBuildInputs = with python2Packages; [ six kerberos rfc6555 ]
++ (if enableProxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it would be better to use lib.optional instead of if (but I think pysocks should be unconditionally added).

@Vonfry
Copy link
Member Author

Vonfry commented Dec 26, 2019

A print by nix path-info -S before and after:

/nix/store/z891lj9c7fdgznnrgqnsmnjdmp4q6nmy-offlineimap-7.3.0	  102404368
/nix/store/h1d7q8r65h2k8wd6vvhixv65q6yk49hw-offlineimap-7.3.0	  102517808

@Vonfry Vonfry requested a review from nlewo December 26, 2019 09:58
@ofborg ofborg bot requested review from Ma27 and endocrimes December 26, 2019 09:58
@Ma27
Copy link
Member

Ma27 commented Dec 26, 2019

A print by nix path-info -S before and after:

While keeping an eye on the closure-size is a good thing to avoid a bloated system-closure, I don't think that an increase of 3MB for an end-user application are a bad thing.

@Vonfry
Copy link
Member Author

Vonfry commented Dec 26, 2019

Thanks, I have added pysocks to the buildInputs instead of an option.

@nlewo nlewo merged commit 8b6bb39 into NixOS:master Dec 26, 2019
@nlewo
Copy link
Member

nlewo commented Dec 26, 2019

Yep, 3MB is definitely not a issue.
Thx!

@Vonfry Vonfry deleted the fix/offlineimap-add-pysocks branch October 6, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

@Ma27 Ma27 Awaiting requested review from Ma27

@endocrimes endocrimes Awaiting requested review from endocrimes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vonfry @nixos-discourse @nlewo @Ma27