Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.Theano: fix darwin build #76327

Merged
merged 1 commit into from Dec 24, 2019
Merged

pythonPackages.Theano: fix darwin build #76327

merged 1 commit into from Dec 24, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 23, 2019

This only formally fixes the name of the compiler. Theano appears to be
working on darwin after this.

Motivation for this change

Closes: #73034

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl
pythonPackages.Theano: fix darwin build
d4f1fa7 
This only formally fixes the name of the compiler. Theano appears to be
working on darwin after this.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 23, 2019
@veprbl
Copy link
Member Author

veprbl commented Dec 23, 2019

@GrahamcOfBorg build python3Packages.Theano
@GrahamcOfBorg build python2Packages.Theano

@ofborg ofborg bot requested a review from bcdarwin December 23, 2019 23:31
@twhitehead
Copy link
Contributor

Looks good to me! Thanks so much for taking care of this one. :)

@veprbl veprbl merged commit 6137058 into NixOS:master Dec 24, 2019
@veprbl veprbl deleted the pr/theano_darwin_fix branch December 24, 2019 17:51
@twhitehead twhitehead mentioned this pull request Jun 4, 2020
Closed
@veprbl veprbl restored the pr/theano_darwin_fix branch December 1, 2020 16:46
@veprbl veprbl deleted the pr/theano_darwin_fix branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twhitehead twhitehead Awaiting requested review from twhitehead

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pymc3 does not install on macos
2 participants
@veprbl @twhitehead