New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pypi2nix #72052
Merged
Merged
Update pypi2nix #72052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Oct 27, 2019
jonringer
reviewed
Oct 28, 2019
pkgs/development/python-modules/nix-prefetch-github/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/nix-prefetch-github/default.nix
Outdated
Show resolved
Hide resolved
seppeljordan
force-pushed
the
update-pypi2nix
branch
from
October 29, 2019 22:20
3a1513f
to
0f3091d
Compare
Okay, I tried to work in the suggestions from the reviews. Thanks for the feedback :) |
@GrahamcOfBorg build pypi2nix |
jonringer
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
pypi2nix seems to work
[11 built, 3 copied (0.8 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72052
7 package were build:
pypi2nix python27Packages.nix-prefetch-github python27Packages.parsley python37Packages.nix-prefetch-github python37Packages.parsley python38Packages.nix-prefetch-github python38Packages.parsley
sweet. thanks everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR should reviewable by commit since each should make sense on its own and now break anything.
Motivation for this change
I want to update
pypi2nix
.Things done
pypi2nix
since it can now easily be packages via the defaultpython.pkgs.buildPythonApplication
pythonPackages.nix-prefetch-github
at version 2.3.1 since it is a dependency ofpypi2nix
pythonPackages.parsley
at version 1.3 since it is a dependency ofpypi2nix
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @