New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keeperrl: init at 2019-10-21 #72051
keeperrl: init at 2019-10-21 #72051
Conversation
libGL, makeWrapper, boost, makeDesktopItem }: | ||
|
||
stdenv.mkDerivation rec { | ||
pname = "keeperrl"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pname = "keeperrl"; | |
pname = "keeperrl-unstable"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or 29.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to include unstable in the version as version = "unstable-2019-10-21"
?
@GrahamcOfBorg build keeperrl |
Co-Authored-By: Marek Mahut <marek.mahut@gmail.com>
src = fetchFromGitHub { | ||
owner = "miki151"; | ||
repo = "keeperrl"; | ||
rev = "74b89ea"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the full revision, not a shorthand form, because shorthand forms can become ambiguous
] ++ stdenv.lib.optional stdenv.isDarwin boost ; | ||
|
||
# Needed so the builder finds SDL.h | ||
CFLAGS = "-I${SDL2.dev}/include/SDL2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think NIX_CFLAGS_COMPILE = [ "-I ..." ]
should be used instead, which will end up in CFLAGS but with some extra stuff.
Thank you for your contributions.
|
Motivation for this change
Late follow up of #43409, updated to the latest stable branch(I think it's alpha29 hotfix1, but there's no tag so I'm not sure.)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @