Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.sushi: fix module loading #72096

Merged
merged 2 commits into from Oct 28, 2019
Merged

gnome3.sushi: fix module loading #72096

merged 2 commits into from Oct 28, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 27, 2019

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/does-anyone-here-uses-sushi-with-nautilus-not-on-gnome/4539/5

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 27, 2019
@ofborg ofborg bot requested review from hedning and worldofpeace October 27, 2019 15:41
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
can't check executable (not running gnome)

[7 built, 2 copied (0.3 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72096
1 package were build:
gnome3.sushi

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change running libexec/org.gnome.NautilusPreviewer would fail with an exception

(.org.gnome.NautilusPreviewer-wrapped:11401): Gjs-WARNING **: 02:28:10.775: JS ERROR: ImportError: No JS module 'ui' found in search path
@/nix/store/4pqlhbgz8882qdlyxa70i9ky4sfpmp19-sushi-3.34.0/libexec/.org.gnome.NautilusPreviewer-wrapped:9:1

Script /nix/store/4pqlhbgz8882qdlyxa70i9ky4sfpmp19-sushi-3.34.0/libexec/.org.gnome.NautilusPreviewer-wrapped threw an exception

This change fixes this and I was able to view a file running sushi after running the previous executable.

Also verified that the file is patched as expected.

@worldofpeace worldofpeace merged commit 7ce9e53 into NixOS:master Oct 28, 2019
@worldofpeace
Copy link
Contributor

backported in 205691b

@jtojnar jtojnar deleted the sushi-fix branch October 28, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants