Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5ct: qtsvg, qmakeFlags nixification #72095

Merged
merged 1 commit into from Oct 27, 2019
Merged

qt5ct: qtsvg, qmakeFlags nixification #72095

merged 1 commit into from Oct 27, 2019

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Oct 27, 2019

Motivation for this change

As discussed in #71463, qt5ct cannot be built for unstable. @dtzWill mentioned a commit solving this situation, but the commit does not appear on any active branch. This PR picks it up for the master.

Fixes: #71463.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ralith @dtzWill

@ofborg ofborg bot requested a review from Ralith October 27, 2019 15:36
Ralith
Ralith approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, though I don't know why it wasn't already PR'd.

@veprbl veprbl merged commit f3a97b2 into NixOS:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qt5ct fails to compile on master
4 participants
@jokogr @Ralith @veprbl @dtzWill