Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #72101

Merged
merged 467 commits into from Oct 28, 2019
Merged

Staging next #72101

merged 467 commits into from Oct 28, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

@FRidh am I able to push to this branch? or does that mess up the hydra jobs?

@FRidh
Copy link
Member Author

FRidh commented Oct 27, 2019

No, you can push. Just remember this is to stabilize. Therefore, mass-rebuilds should only go in when they're critical.

@jonringer
Copy link
Contributor

I think a lot of my mass re-builds were already done as part of the python-unstable period

@FRidh
Copy link
Member Author

FRidh commented Oct 27, 2019

let ofborg do the eval check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants