Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colord-gtk: 0.1.26 → 0.2.0 #72104

Merged
merged 1 commit into from Oct 27, 2019
Merged

colord-gtk: 0.1.26 → 0.2.0 #72104

merged 1 commit into from Oct 27, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 27, 2019

license = stdenv.lib.licenses.lgpl2Plus;
platforms = stdenv.lib.platforms.linux;
meta = with stdenv.lib; {
homepage = "http://www.freedesktop.org/software/colord/intro.html";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = "http://www.freedesktop.org/software/colord/intro.html";
homepage = "https://www.freedesktop.org/software/colord/intro.html";

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seemed fine in gnome-color-manager. g-c-c builds.
Inspected outputs.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah 😄 retract that.

I believe we should propagate gtk3 and colord as per the .pc.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@worldofpeace worldofpeace merged commit cd04433 into NixOS:master Oct 27, 2019
@jtojnar jtojnar deleted the colord-gtk branch October 28, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants