Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shotgun: init at 2.2.0 #72100

Merged
merged 1 commit into from Oct 28, 2019
Merged

shotgun: init at 2.2.0 #72100

merged 1 commit into from Oct 28, 2019

Conversation

lumi-me-not
Copy link
Contributor

Motivation for this change

Adding the shotgun package. This is an X11 screen capture tool.

Repository: https://github.com/neXromancers/shotgun

I've also added myself to maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

rasendubi
rasendubi reviewed Oct 27, 2019
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to pass all dependencies explicitly but otherwise, the diff looks good.

pkgs/tools/graphics/shotgun/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/shotgun/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/shotgun/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/shotgun/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/shotgun/default.nix Outdated Show resolved Hide resolved
@rasendubi
Copy link
Member

@GrahamcOfBorg build shotgun

@lumi-me-not
Copy link
Contributor Author

Thanks for the help! I've done all of the suggested modifications. :)

@rasendubi
Copy link
Member

Could you take a look at aarch64 failure? https://logs.nix.ci/?key=nixos/nixpkgs.72100&attempt_id=5f20f4d4-9951-48dc-9297-78efdf332769

error[E0308]: mismatched types
   --> src/xwrap.rs:251:30
    |
251 |         xlib::XParseGeometry(g.as_ptr() as *const i8, &mut x, &mut y, &mut w, &mut h);
    |                              ^^^^^^^^^^^^^^^^^^^^^^^ expected u8, found i8
    |
    = note: expected type `*const u8`
               found type `*const i8`

It looks like an upstream issue and might be easy to fix. Could you report it?

For now, we can add "aarch64-linux" to meta.badPlatforms.

@lumi-me-not
Copy link
Contributor Author

Did the modification, I'll look into what's causing this issue.

@rasendubi
Copy link
Member

@GrahamcOfBorg eval
@GrahamcOfBorg build shotgun

@lumi-me-not lumi-me-not mentioned this pull request Oct 27, 2019
Merged
jonringer
jonringer approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work (took a screenshot)

[4 built, 1 copied, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72100
1 package were build:
shotgun

[nix-shell:/home/jon/.cache/nix-review/pr-72100]$ nix path-info -Sh ./results/shotgun
/nix/store/mp4km7ymd4424z69yc3f8g7wcmgipswk-shotgun-2.2.0         31.7M

@jonringer jonringer merged commit ac2d736 into NixOS:master Oct 28, 2019
@lumi-me-not lumi-me-not deleted the add-shotgun-2.2.0 branch October 20, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lumi-me-not @rasendubi @jonringer @Janik-Haag