For me, it makes sense to only reset time_since_pickup when cargo is actually loaded, not before. If a train with spare capacity for some cargo comes into a station, but for some reason doesn't pick any up, the cargo is still "old" and the pickup time shouldn't be reset. It's time since cargo pick up, not time since last (nonfull) train arrival

The time since load needs to be reset even when there is no cargo available to load on the station, since that value is used for station rating calculation. If a player that doesn't receive any cargo on their station due to low rating can't raise their rating by having vehicles attempt to load, they will never be able to compete.

I haven't looked at the code in detail, but the idea presented sounds reasonable.

I've split the PR into two commits:

• The first one contains the functional changes; making if (cap_left > 0) { its own branch and only setting ge->time_since_pickup = 0; in there. Note the wrong indentation.
• And the second one just fixes the indentation (which produces a big diff)

Should be a little easier to review (edit: though it will fail the commit checker)

Alright, squashed, looks like github automatically dismissed the review on force push unfortunately. I'm not too familiar with gh's system.

Copy of old commit without indentation: MingweiSamuel@d0c1353