Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mu-repo: init at 1.8.0 #71992

Merged
merged 1 commit into from Oct 27, 2019
Merged

mu-repo: init at 1.8.0 #71992

merged 1 commit into from Oct 27, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Oct 25, 2019

Motivation for this change

mu-repo - a tool to help in dealing with multiple git repositories.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/nc014syiz00283yl7v13jaz0r217a5ff-mu-repo-1.8.0
/nix/store/nc014syiz00283yl7v13jaz0r217a5ff-mu-repo-1.8.0	  96.6M

jonringer
jonringer approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71992
1 package were build:
mu-repo

just some preferences listed below

pkgs/applications/misc/mu-repo/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mu-repo/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mu-repo/default.nix Outdated Show resolved Hide resolved
@rasendubi
Copy link
Member

@GrahamcOfBorg build mu-repo

@rasendubi
Copy link
Member

Could take a look at a test failure on darwin?

E               subprocess.CalledProcessError: Command '['git', 'rev-parse', '--abbrev-ref', 'HEAD']' returned non-zero exit status 128.
/nix/store/jn8dic1klsd1d550wb682ssnq9wsffg5-python3-3.7.5/lib/python3.7/subprocess.py:512: CalledProcessError
----------------------------- Captured stdout call -----------------------------
Initialized empty Git repository in /private/tmp/nix-build-mu-repo-1.8.0.drv-0/source/test_temp_dir/lib/.git/
Initialized empty Git repository in /private/tmp/nix-build-mu-repo-1.8.0.drv-0/source/test_temp_dir/app/.git/
----------------------------- Captured stderr call -----------------------------
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

@sikmir
Copy link
Member Author

sikmir commented Oct 26, 2019

Could take a look at a test failure on darwin?

Maybe CI got another git version, as far as build is OK on my macOS.

@rasendubi
Copy link
Member

Not sure. We're bringing the git as checkInputs so it should be the same.

The error looks like it's try to access the HEAD of an empty repository with no commits. At least, that's what I've googled up and I can't think of any other possible cause.

I think that maybe the test is unstable, so let's restart the build to figure out (maybe).

@GrahamcOfBorg build mu-repo

@jonringer
Copy link
Contributor

@GrahamcOfBorg build mu-repo

@rasendubi rasendubi merged commit 6f98994 into NixOS:master Oct 27, 2019
@sikmir sikmir deleted the mu-repo branch October 27, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @rasendubi @jonringer