Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melpa-packages: 2019-10-25 #71990

Merged
merged 1 commit into from Oct 26, 2019
Merged

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Oct 25, 2019

The previous update included several errors which broke packages. This
one re-fetched and fixed them.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

The previous update included several errors which broke packages. This
one re-fetched and fixed them.
@adisbladis
Copy link
Member

Thanks!

Btw, would you mind pinging me on IRC when you have time?

@adisbladis adisbladis merged commit 5cd2781 into NixOS:master Oct 26, 2019
@benley benley mentioned this pull request Nov 8, 2019
10 tasks
@veprbl
Copy link
Member

veprbl commented Dec 28, 2019

The hashes might have changed again: #71948 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants