DCMTK: init at 3.6.4 #71991
Merged
DCMTK: init at 3.6.4 #71991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Oct 25, 2019
prusnak
reviewed
Oct 25, 2019
prusnak
reviewed
Oct 25, 2019
prusnak
reviewed
Oct 25, 2019
jonringer
reviewed
Oct 25, 2019
| description = "DICOM Toolkit"; | ||
| longDescription = '' | ||
| DCMTK is a collection of libraries and applications implementing large parts of the DICOM standard. | ||
| It includes software for examining, constructing and converting DICOM image files, handling offline media, sending and receiving images over a network connection, as well as demonstrative image storage and worklist servers. |
There was a problem hiding this comment.
this line is too long
Suggested change
| It includes software for examining, constructing and converting DICOM image files, handling offline media, sending and receiving images over a network connection, as well as demonstrative image storage and worklist servers. | |
| It includes software for examining, constructing and converting DICOM image files, handling offline media, | |
| sending and receiving images over a network connection, as well as demonstrative image storage and worklist servers. |
|
Thanks @prusnak and @jonringer for your reviews. I agree with all your suggestions. What is the preferred way to incorporate them. Should I make these changes and force push them so it remains a single commit? In this case you will probably not be credited for you suggested changes (or is there a way to do that?). |
|
Yes, amend the commit and force push to branch. No need for credit I'd say |
|
LGTM |
rasendubi
reviewed
Oct 26, 2019
|
@rasendubi thanks for catching that. I just force pushed your suggested changes |
|
@GrahamcOfBorg build dcmtk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the DICOM Toolkit DCMTK as package. It is a command line suite to handle medical imaging data in DICOM format. Including inspection, modification, and conversion.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @