Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tatsu: init at 4.4.0, ics: init at 0.6 #72111

Merged
merged 2 commits into from Oct 27, 2019
Merged

tatsu: init at 4.4.0, ics: init at 0.6 #72111

merged 2 commits into from Oct 27, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 27, 2019

Motivation for this change

Successfully tested the ics library. The expression for tatsu is a bit hacky :o
Optional TODOs:

  • Should the attribute for TatSu be case-sensitive?
  • Fixing the tests (goes a bit beyond my Python knowledge...)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

primeos and others added 2 commits October 27, 2019 19:17
@primeos @jonringer
python37Packages.tatsu: init at 4.4.0
e15efb8 
Co-authored-by: Jonathan Ringer <jonringer117@gmail.com>
@primeos
python37Packages.ics: init at 0.6
426803c
@primeos
Copy link
Member Author

primeos commented Oct 27, 2019

@jonringer awesome, that did fix the tests :) Thank you very much for your help!

jonringer
jonringer approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
both have tests
executables in tatsu seem to work

[7 built, 6 copied (0.4 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72111
4 package were build:
python37Packages.ics python37Packages.tatsu python38Packages.ics python38Packages.tatsu

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.ics python37Packages.tatsu python38Packages.ics python38Packages.tatsu

@jonringer jonringer merged commit f2be56e into NixOS:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @jonringer