Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbterm: fix cross-build #72107

Merged
merged 1 commit into from Oct 28, 2019
Merged

fbterm: fix cross-build #72107

merged 1 commit into from Oct 28, 2019

Conversation

lheckemann
Copy link
Member

Motivation for this change

Cross-compilation!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lheckemann added a commit to lheckemann/mobile-nixos that referenced this pull request Oct 27, 2019
Requires a cross-compilation fix for fbterm (NixOS/nixpkgs#72107).

This may stop the display-manager from starting correctly, I think it
prevents X from automatically switching to the correct vt. Requires
some further investigation :)
@ofborg ofborg bot requested a review from 7c6f434c October 27, 2019 17:36
lheckemann added a commit to lheckemann/mobile-nixos that referenced this pull request Oct 27, 2019
Requires a cross-compilation fix for fbterm (NixOS/nixpkgs#72107).

This may stop the display-manager from starting correctly, I think it
prevents X from automatically switching to the correct vt. Requires
some further investigation :)
@lheckemann lheckemann merged commit 5d20246 into NixOS:master Oct 28, 2019
@lheckemann lheckemann deleted the fbterm-cross branch October 28, 2019 09:10
lheckemann added a commit to lheckemann/mobile-nixos that referenced this pull request Oct 28, 2019
Requires a cross-compilation fix for fbterm (NixOS/nixpkgs#72107).

This may stop the display-manager from starting correctly, I think it
prevents X from automatically switching to the correct vt. Requires
some further investigation :)

(cherry picked from commit fc65911)
lheckemann added a commit to lheckemann/mobile-nixos that referenced this pull request Nov 16, 2019
Requires a cross-compilation fix for fbterm (NixOS/nixpkgs#72107).

This may stop the display-manager from starting correctly, I think it
prevents X from automatically switching to the correct vt. Requires
some further investigation :)
lheckemann added a commit to lheckemann/mobile-nixos that referenced this pull request Nov 16, 2019
Requires a cross-compilation fix for fbterm (NixOS/nixpkgs#72107).

This may stop the display-manager from starting correctly, I think it
prevents X from automatically switching to the correct vt. Requires
some further investigation :)

(cherry picked from commit fc65911)
lheckemann added a commit to lheckemann/mobile-nixos that referenced this pull request Nov 16, 2019
Requires a cross-compilation fix for fbterm (NixOS/nixpkgs#72107).

This may stop the display-manager from starting correctly, I think it
prevents X from automatically switching to the correct vt. Requires
some further investigation :)

(cherry picked from commit fc65911)
danielfullmer pushed a commit to danielfullmer/mobile-nixos that referenced this pull request Nov 19, 2019
Requires a cross-compilation fix for fbterm (NixOS/nixpkgs#72107).

This may stop the display-manager from starting correctly, I think it
prevents X from automatically switching to the correct vt. Requires
some further investigation :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants