[staging-next] pythonPackages fixes #72105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also had tbm-utils, audio-metadata, and one other, but you already got to them :) |
|
I'm going to do a few more package fixes if you don't mind. Don't merge for a little while :) |
FRidh
reviewed
Oct 27, 2019
prusnak
requested changes
Oct 27, 2019
There was a problem hiding this comment.
Pyro4 build fails with the following for me:
$ nix-shell -I nixpkgs=. -p python3Packages.Pyro4
...
...
...
=================================== FAILURES ===================================
__________________________ TestSSL.testContextAndSock __________________________
self = <PyroTests.test_socket.TestSSL testMethod=testContextAndSock>
def testContextAndSock(self):
cert_dir = "../../certs"
if not os.path.isdir(cert_dir):
cert_dir = "../certs"
if not os.path.isdir(cert_dir):
> self.fail("cannot locate test certs directory")
E AssertionError: cannot locate test certs directory
tests/PyroTests/test_socket.py:568: AssertionError
=============================== warnings summary ===============================
tests/PyroTests/test_socket.py:375
/build/Pyro4-4.75/tests/PyroTests/test_socket.py:375: PytestCollectionWarning: cannot collect test class 'TestDaemon' because it has a __init__ constructor (from: tests/PyroTests/test_socket.py)
class TestDaemon(Daemon):
-- Docs: https://docs.pytest.org/en/latest/warnings.html
= 1 failed, 602 passed, 20 skipped, 6 deselected, 1 warnings in 77.65s (0:01:17) =
|
are you on darwin? |
|
@jonringer no: |
|
@GrahamcOfBorg build python27Packages.Pyro4 python37Packages.Pyro4 python38Packages.Pyro4 |
|
@prusnak do you have an overlay present? ofborg was able to build on aarch-linux |
|
hmm no ... |
|
seeing as these builds are broken on staging-next, I'm going to merge, worse case, their still broken for some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
some package fixes
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @