Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaff: init at 0.1.1 #72108

Merged
merged 1 commit into from
Feb 10, 2020
Merged

scaff: init at 0.1.1 #72108

merged 1 commit into from
Feb 10, 2020
+28 −0

Conversation

jD91mZM2
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 27, 2019
@ckauhaus
Copy link
Contributor

@GrahamcOfBorg build scaff

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Jan 7, 2020

Is a bump allowed?

@ckauhaus
Copy link
Contributor

ckauhaus commented Jan 7, 2020

Of course - go ahead

@ckauhaus
Copy link
Contributor

ckauhaus commented Jan 7, 2020

What bugs me a bit is potential pkgs tree bloat. The diff is quite huge for such a simple tool.

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Jan 7, 2020

Understandable! Feel free to close this if you don't see it fitting in nixpkgs :)

@ckauhaus
Copy link
Contributor

ckauhaus commented Jan 7, 2020

Even better would be to get it in with less nix code. Is there a possibility to use alternative Rust build support?

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Jan 8, 2020

Sure! It just takes longer to build, but it's definitely possible. Will do ASAP :)

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Jan 9, 2020

Finally, done. Apologies for the delay :)

@ckauhaus
Copy link
Contributor

@jD91mZM2 The pkg definition is missing a metadata section.

@jD91mZM2
Copy link
Member Author

Oh, oops, sorry

@ckauhaus
Copy link
Contributor

ckauhaus commented Feb 5, 2020

@jD91mZM2 ping - any news here? Just add a metadata section and it's done.

@jD91mZM2
Copy link
Member Author

jD91mZM2 commented Feb 5, 2020

Oh, I forgot this, thanks for the ping!

@ckauhaus ckauhaus merged commit b2abf36 into NixOS:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jD91mZM2 @ckauhaus