scaff: init at 0.1.1 #72108
Merged
scaff: init at 0.1.1 #72108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build scaff |
|
Is a bump allowed? |
|
Of course - go ahead |
|
What bugs me a bit is potential pkgs tree bloat. The diff is quite huge for such a simple tool. |
|
Understandable! Feel free to close this if you don't see it fitting in nixpkgs :) |
|
Even better would be to get it in with less nix code. Is there a possibility to use alternative Rust build support? |
|
Sure! It just takes longer to build, but it's definitely possible. Will do ASAP :) |
|
Finally, done. Apologies for the delay :) |
|
@jD91mZM2 The pkg definition is missing a metadata section. |
|
Oh, oops, sorry |
|
@jD91mZM2 ping - any news here? Just add a metadata section and it's done. |
|
Oh, I forgot this, thanks for the ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)