Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neomutt: 20180716 -> 2019-10-25 #71984

Merged
merged 1 commit into from Oct 29, 2019
Merged

neomutt: 20180716 -> 2019-10-25 #71984

merged 1 commit into from Oct 29, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 25, 2019 •
edited

Motivation for this change

https://github.com/neomutt/neomutt/releases/tag/2019-10-25

Please note that this is a release with a lot of changes (according to upstream), so we should have this tested by several people before merging :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
Copy link
Contributor

risicle commented Oct 27, 2019

nix-review WFM macos 10.13

@gebner
Copy link
Member

gebner commented Oct 29, 2019

Works for me as well.

@gebner gebner merged commit 0008400 into NixOS:master Oct 29, 2019
@Ma27 Ma27 deleted the bump-neomutt branch October 29, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@cstrahan cstrahan Awaiting requested review from cstrahan

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @risicle @gebner