Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass-checkup: Remove trailing dot #71985

Merged
merged 1 commit into from Oct 25, 2019
Merged

pass-checkup: Remove trailing dot #71985

merged 1 commit into from Oct 25, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 25, 2019

Motivation for this change

Minor fixup after #71919

cc @worldofpeace

@worldofpeace
Copy link
Contributor

Thanks 👍

@worldofpeace worldofpeace merged commit d767d5d into NixOS:master Oct 25, 2019
@etu etu deleted the pass-checkup-trailing-dot branch October 25, 2019 15:03
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 25, 2019

BTW when overriding a whole phase you should run the pre- and post- hooks. :p
(but don't make a PR just for that, it can be fixed at the next pkg update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @worldofpeace @c0bw3b