zstd: add static option #72069
Closed
zstd: add static option #72069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake is used for static builds because the Makefile does not offer a way to disable the shared library.
tobim
force-pushed
the
pkgsStatic/zstd
branch
from
2bdfef2
to
4833b69
Compare
|
Isn't it possible to build both shared & static in one common multi-outputs derivation (with CMake) ; and then install static lib in "static" output ? |
|
The regular Makefile based build already builds The purpose of this PR is mostly to get |
matthewbauer
reviewed
Nov 3, 2019
| @@ -59,4 +60,15 @@ stdenv.mkDerivation rec { | |||
| platforms = platforms.unix; | |||
| maintainers = with maintainers; [ orivej ]; | |||
| }; | |||
| } | |||
| } // stdenv.lib.optionalAttrs static { | |||
| nativeBuildInputs = [ cmake ]; | |||
There was a problem hiding this comment.
It would be good if we can use cmake on non-static as well.
There was a problem hiding this comment.
Done in the second commit.
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
superseded by #75798. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake is used for static builds because the Makefile does not
offer a way to disable the shared library.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @orivej