builtins.toJSON: fix __toString usage #3167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the evaluation of an attrs using
__toString
withbuiltins.toJSON
:Before:
Now:
I tried to abstract this away a bit to not duplicate the logic.
Also I'm not happy about the
noPos
in thetoJSON
case, but I couldn't figure out how to get a correctPos
and I think that shouldn't be shown anyway.cc @Ericson2314 who helped me find the error