Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/magnetico: fixes #72012

Merged
merged 4 commits into from
Nov 17, 2019
Merged

nixos/magnetico: fixes #72012

merged 4 commits into from
Nov 17, 2019
+24 −10

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 26, 2019

Motivation for this change

Fix some stupid mistakes I did.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via nixos/tests/magnetico.nix
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 26, 2019
prusnak
prusnak reviewed Oct 26, 2019
View reviewed changes
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 8, 2019

ping

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

@GrahamcOfBorg test magnetico

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

It's not referenced in all-tests.nix ?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 13, 2019

It's not referenced in all-tests.nix ?

Found another mistake.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 13, 2019

I added the test to all-tests.nix, ported it to the python driver and fixed a race condition in.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

@GrahamcOfBorg test magnetico

@rnhmjoj
nixos/magnetico: fixes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
dda2f64
@rnhmjoj
nixos/tests/magnetico: check for different web port
6823199
@rnhmjoj
nixos/tests/magnetico: port to python
f6a8eb2
@rnhmjoj
nixos/magnetico: order after network.target
8464867
@c0bw3b c0bw3b merged commit 07f5d3b into NixOS:master Nov 17, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 17, 2019

Thank you

@rnhmjoj rnhmjoj mentioned this pull request Nov 17, 2019
Merged
7 tasks
@rnhmjoj rnhmjoj mentioned this pull request Nov 30, 2019
Closed
@rnhmjoj rnhmjoj deleted the magnetico branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak

@c0bw3b c0bw3b

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @c0bw3b @prusnak