Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/magnetico: fixes #72012

Merged
merged 4 commits into from Nov 17, 2019
Merged

nixos/magnetico: fixes #72012

merged 4 commits into from Nov 17, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 26, 2019

Motivation for this change

Fix some stupid mistakes I did.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via nixos/tests/magnetico.nix
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak reviewed Oct 26, 2019
View reviewed changes
nixos/tests/magnetico.nix Outdated Show resolved Hide resolved
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 8, 2019

ping

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

@GrahamcOfBorg test magnetico

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

It's not referenced in all-tests.nix ?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 13, 2019

It's not referenced in all-tests.nix ?

Found another mistake.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 13, 2019

I added the test to all-tests.nix, ported it to the python driver and fixed a race condition in.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

@GrahamcOfBorg test magnetico

@c0bw3b c0bw3b merged commit 07f5d3b into NixOS:master Nov 17, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 17, 2019

Thank you

@rnhmjoj rnhmjoj mentioned this pull request Nov 17, 2019
Merged
7 tasks
@rnhmjoj rnhmjoj mentioned this pull request Nov 30, 2019
Closed
@rnhmjoj rnhmjoj deleted the magnetico branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @c0bw3b @prusnak