Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Znapzend improvements #72080

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Conversation

infinisil
Copy link
Member

Motivation for this change
  • Adds options features.compressed to use -Lce for sending and features.recvu to allow destination filesystems to be unmounted. See man znapzend for info on these features.
  • Fixes the service timing out when starting when a destination host is offline.

Ping @lheckemann

Things done
  • Made sure both commits have the intended changes in my local system

Sorry, something went wrong.

Unverified

The email in this signature doesn’t match the committer email.

Unverified

The email in this signature doesn’t match the committer email.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 27, 2019
@lheckemann
Copy link
Member

Could we also enable them by default (with a release notes entry 😉)?

@lheckemann
Copy link
Member

(and thanks very much for implementing this!)

@infinisil
Copy link
Member Author

@lheckemann I thought about it, but enabling them could break for people who have e.g. embedded_data enabled on the sending side, but disabled on the receiving one, same for other features. I think by default these are off in znapzend because of this too.

@lheckemann
Copy link
Member

Hence the release notes entry ;)

But let's start with merging this and consider changing it separately.

# service timeout of 90 seconds. Increase the timeout so it doesn't
# make the service fail in that case.
TimeoutStartSec = 180;
# Needs to have write access to ZFS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lheckemann lheckemann merged commit e7a6123 into NixOS:master Oct 28, 2019
@lheckemann
Copy link
Member

In retrospect, this should probably be a per-destination property since different destination pools may support different features.

@infinisil
Copy link
Member Author

@lheckemann Unfortunately znapzend doesn't support this :/

@infinisil infinisil deleted the znapzend-improvements branch November 1, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants