-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Znapzend improvements #72080
Znapzend improvements #72080
Conversation
Could we also enable them by default (with a release notes entry 😉)? |
(and thanks very much for implementing this!) |
@lheckemann I thought about it, but enabling them could break for people who have e.g. |
Hence the release notes entry ;) But let's start with merging this and consider changing it separately. |
# service timeout of 90 seconds. Increase the timeout so it doesn't | ||
# make the service fail in that case. | ||
TimeoutStartSec = 180; | ||
# Needs to have write access to ZFS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't necessarily require root (https://github.com/oetiker/znapzend/blob/master/README.md#running-by-an-unprivileged-user)
In retrospect, this should probably be a per-destination property since different destination pools may support different features. |
@lheckemann Unfortunately znapzend doesn't support this :/ |
Motivation for this change
features.compressed
to use-Lce
for sending andfeatures.recvu
to allow destination filesystems to be unmounted. Seeman znapzend
for info on these features.Ping @lheckemann
Things done