Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tuxguitar: 1.2 -> 1.5.2 #72081

Merged
merged 1 commit into from Oct 27, 2019
Merged

tuxguitar: 1.2 -> 1.5.2 #72081

merged 1 commit into from Oct 27, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 27, 2019 •
edited

Motivation for this change

Update from 1.2 to 1.5.2 as requested in #68814

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak prusnak mentioned this pull request Oct 27, 2019
Closed
@mmahut
Copy link
Member

mmahut commented Oct 27, 2019

@GrahamcOfBorg build tuxguitar

@mmahut mmahut merged commit 823b8ed into NixOS:master Oct 27, 2019
@prusnak prusnak deleted the tuxguitar branch October 27, 2019 15:50
@uzr123x
Copy link

uzr123x commented Nov 2, 2019

Good to hear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mmahut @uzr123x