Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/i18n: use str instead of string for consoleKeyMap #71999

Merged
merged 1 commit into from Oct 25, 2019
Merged

nixos/i18n: use str instead of string for consoleKeyMap #71999

merged 1 commit into from Oct 25, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

Previously multiple definitions of i18n.consoleKeyMap were incorrectly merged, leading to a build error similar to this:

building '/nix/store/<...>-keymap.drv'...
cannot open file usus
builder for '/nix/store/<...>-keymap.drv' failed with exit code 1
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz WilliButz merged commit 95f1a9a into NixOS:master Oct 25, 2019
@WilliButz WilliButz deleted the fix-i18n branch October 25, 2019 22:50
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 26, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 26, 2019

Backporting to release-19.09. The error message is pretty confusing and hard to track down.

@Ma27
Copy link
Member

Ma27 commented Oct 26, 2019

Backportd as 12414f8. Thanks!

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @Ma27 @infinisil