Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropbox: add version to package name #72087

Closed
wants to merge 1 commit into from
Closed

dropbox: add version to package name #72087

wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 27, 2019 •
edited

Motivation for this change

Otherwise, it is very hard to figure out what version of dropbox we're actualy running.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bhipple
dropbox: add version to package name
95c943f 
Otherwise, it is very hard to figure out what version of dropbox we're actualy running.
@bhipple
Copy link
Contributor Author

bhipple commented Oct 27, 2019

On master, we get

/nix/store/b7pv3fvyxvlk4wgi1vbwfli5l876b79l-dropbox

but with this change we get a more conventional package name:

/nix/store/x8c9dp6ibyxs2m869ajc0yd8s8q74885-dropbox-81.4.195

@mmahut mmahut requested a review from ttuegel October 27, 2019 14:00
@bhipple
Copy link
Contributor Author

bhipple commented Oct 29, 2019

Oh, I see doing this renames the binary in $PATH to dropbox-81.4.195 as well, which is not ideal.

@bhipple bhipple closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bhipple