Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezor-udev-rules: init at unstable-2019-07-17 #72089

Merged
merged 1 commit into from Oct 31, 2019
Merged

trezor-udev-rules: init at unstable-2019-07-17 #72089

merged 1 commit into from Oct 31, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 27, 2019 •
edited

Motivation for this change

Let's create a separate udev rules package for Trezor so it works when a user installs pythonPackages.trezor or trezord packages manually and not via enabling the service via services.trezord.enable. Currently, the udev rules are installed only when the service is enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak
Copy link
Member Author

prusnak commented Oct 27, 2019

Please review @mmahut @1000101

@mmahut
Copy link
Member

mmahut commented Oct 27, 2019

Looks good at first glance, will test it in the evening.

@GrahamcOfBorg build trezor-udev-rules
@GrahamcOfBorg test trezord

@ofborg ofborg bot requested review from ehmry, 1000101, jb55, np and mmahut October 27, 2019 14:46
@mmahut
Copy link
Member

mmahut commented Oct 29, 2019

@GrahamcOfBorg build trezor-udev-rules
@GrahamcOfBorg test trezord

@prusnak prusnak marked this pull request as ready for review October 29, 2019 11:19
@ofborg ofborg bot requested a review from mmahut October 29, 2019 12:59
@mmahut
Copy link
Member

mmahut commented Oct 29, 2019

@GrahamcOfBorg build trezor-udev-rules
@GrahamcOfBorg test trezord

@mmahut
Copy link
Member

mmahut commented Oct 29, 2019

Failure on aarch64, I guess this is unrelated.

@GrahamcOfBorg build trezor-udev-rules
@GrahamcOfBorg test trezord

@ofborg ofborg bot requested a review from 1000101 October 30, 2019 14:30
@mmahut
Copy link
Member

mmahut commented Oct 31, 2019

@GrahamcOfBorg build trezor-udev-rules
@GrahamcOfBorg test trezord

@mmahut mmahut merged commit 392b12f into NixOS:master Oct 31, 2019
@prusnak prusnak deleted the trezor-udev-rules branch October 31, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@jb55 jb55 Awaiting requested review from jb55

@np np Awaiting requested review from np

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mmahut @1000101