Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to geometry to support the inertia tensor #2364

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 26, 2019

Also a bit of cleanup on old code.

result_row_z.coordinates());

// The averaging below ensures that the result is symmetric.
// TODO(phl): Investigate if using a Cholesky or LDL decomposition would help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue to track this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eggrobin eggrobin added the LGTM label Oct 26, 2019
@pleroy pleroy merged commit ca0c5c9 into mockingbirdnest:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants