Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3afeb36fd0b9
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 81b32ec6f374
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 25, 2019

  1. epsxe: fix link with openssl 

    * epsxe: fix link with openssl

Epsxe is hardcoded to build with openssl-1.0 (using libcrypto.so.1.0.0),
but current nixpkgs contains openssl-1.1, which provides
libcrypto.so.1.1.

This patchs just uses the previous version of the library.

* epsxe: use autoPatchelfHook instead of manual rpath overriding

This simplifies the file AND generates failures at build time if a
needed dynamic library is not found during build time.

Backport of #71920

(cherry picked from commit 4a2475c)
    @guibou @c0bw3b
    guibou authored and c0bw3b committed Oct 25, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    kampka Christian Kampka
    GPG key ID: B88E140DB4FE1AA5
    Verified
    Learn about vigilant mode
    Copy the full SHA
    81b32ec View commit details
Showing with 3 additions and 7 deletions.
  1. +3 −7 pkgs/misc/emulators/epsxe/default.nix
10 changes: 3 additions & 7 deletions pkgs/misc/emulators/epsxe/default.nix
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ stdenv, fetchurl, alsaLib, curl, gdk-pixbuf, glib, gtk3, libGLU_combined,
libX11, openssl, ncurses5, SDL, SDL_ttf, unzip, zlib, wrapGAppsHook }:
libX11, openssl_1_0_2, ncurses5, SDL, SDL_ttf, unzip, zlib, wrapGAppsHook, autoPatchelfHook }:

with stdenv.lib;

@@ -17,7 +17,7 @@ stdenv.mkDerivation rec {
else "1677lclam557kp8jwvchdrk27zfj50fqx2q9i3bcx26d9k61q3kl";
};

nativeBuildInputs = [ unzip wrapGAppsHook ];
nativeBuildInputs = [ unzip wrapGAppsHook autoPatchelfHook ];
sourceRoot = ".";

buildInputs = [
@@ -28,7 +28,7 @@ stdenv.mkDerivation rec {
gtk3
libX11
libGLU_combined
openssl
openssl_1_0_2
ncurses5
SDL
SDL_ttf
@@ -40,10 +40,6 @@ stdenv.mkDerivation rec {

installPhase = ''
install -D ${if stdenv.is64bit then "epsxe_x64" else "ePSXe"} $out/bin/epsxe
patchelf \
--set-interpreter $(cat ${stdenv.cc}/nix-support/dynamic-linker) \
--set-rpath ${makeLibraryPath buildInputs} \
$out/bin/epsxe
'';

meta = {