Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] php: 7.2.23 -> 7.2.24, 7.3.10 -> 7.3.11 #71995

Merged
merged 1 commit into from Oct 25, 2019
Merged

[19.09] php: 7.2.23 -> 7.2.24, 7.3.10 -> 7.3.11 #71995

merged 1 commit into from Oct 25, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 25, 2019

Motivation for this change

(cherry picked from commit a480006)

Backport of #71968

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu
Copy link
Contributor Author

etu commented Oct 25, 2019

cc @aanderse

@ofborg ofborg bot requested a review from globin October 25, 2019 18:21
KamilaBorowska
KamilaBorowska approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@KamilaBorowska KamilaBorowska left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied this patch on my server's production that uses php-fpm 7.3 and hosts Nextcloud, production still works.

@globin globin merged commit ef1598a into NixOS:release-19.09 Oct 25, 2019
@etu etu deleted the php-updates-release-1909 branch October 25, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @KamilaBorowska @globin @aanderse